Exactly, that's my hope too :-) Hopefully the numbers will be enough to convince us the work is worth doing.
On Wed, May 4, 2011 at 2:57 PM, Ray Ryan <[email protected]> wrote: > Once we've validated the work, seems like a lot of the Attachable support > should be baked into UiObject, Widget and Panel in some kind of opt-in > manner. > > On Wed, May 4, 2011 at 10:20 AM, Rafael Castro <[email protected]>wrote: > >> Liked it. With the stuff I added to our subclass of AttachableHTMLPanel, >> this already works pretty well. I have to review some other tricky cases >> (like if you add a non-attachable widget to an Attachable panel before >> finishing the initialization), but we're pretty close. The other cases that >> could trigger this is calling some UIObject method that we haven't yet >> @Override (like we did for setStyleName). Those call getElement() and hurt >> us. >> >> >> On Wed, May 4, 2011 at 2:15 PM, <[email protected]> wrote: >> >>> How's that? >>> >>> Is the bit I wrote about "after adding it to a panel" accurate? Seems >>> like we're trying to get to a world where the add would be fine, and the >>> wrap call wouldn't happen until the parent is wrapped — are we there >>> already? >>> >>> >>> >>> http://gwt-code-reviews.appspot.com/1427812/diff/6003/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java >>> >>> File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java >>> (right): >>> >>> >>> http://gwt-code-reviews.appspot.com/1427812/diff/6003/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java#newcode211 >>> user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java:211: >>> throw new IllegalStateException( >>> wrapElement() cannot be called twice, or after a call to getElement() >>> has forced the widget to render itself (e.g. after adding it to a panel) >>> >>> >>> http://gwt-code-reviews.appspot.com/1427812/ >>> >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
