Revision: 10147
Author: [email protected]
Date: Thu May 5 09:42:56 2011
Log: Give the UiBinder safehtml warning once per compile.
Review at http://gwt-code-reviews.appspot.com/1434801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=10147
Modified:
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DockPanelParser.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/TabPanelParser.java
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DockPanelParser.java
Mon Jun 21 06:45:34 2010
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DockPanelParser.java
Thu May 5 09:42:56 2011
@@ -43,9 +43,6 @@
public void parse(XMLElement elem, String fieldName, JClassType type,
UiBinderWriter writer) throws UnableToCompleteException {
- writer.warn(elem,
- "%1$s:%2$s is deprecated. Use the %1$s:DockLayoutPanel instead.",
- elem.getPrefix(), elem.getLocalName());
// Parse children.
for (XMLElement child : elem.consumeChildElements()) {
// DockPanel can only contain Dock elements.
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java
Mon Jun 7 12:20:31 2010
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java
Thu May 5 09:42:56 2011
@@ -29,9 +29,6 @@
public void parse(XMLElement elem, String fieldName, JClassType type,
UiBinderWriter writer) throws UnableToCompleteException {
- writer.warn(elem,
- "%1$s:%2$s is deprecated. Use the %1$s:StackLayoutPanel instead.",
- elem.getPrefix(), elem.getLocalName());
// Parse children.
for (XMLElement child : elem.consumeChildElements()) {
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/TabPanelParser.java
Wed Mar 9 09:01:28 2011
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/TabPanelParser.java
Thu May 5 09:42:56 2011
@@ -30,9 +30,6 @@
public void parse(XMLElement panelElem, String fieldName, JClassType
type,
UiBinderWriter writer) throws UnableToCompleteException {
- writer.warn(panelElem,
- "%1$s:%2$s is deprecated. Use the %1$s:TabLayoutPanel instead.",
- panelElem.getPrefix(), panelElem.getLocalName());
// Parse children.
for (XMLElement tabElem : panelElem.consumeChildElements()) {
// TabPanel can only contain Tab elements.
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
Mon Apr 25 11:52:46 2011
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
Thu May 5 09:42:56 2011
@@ -49,6 +49,8 @@
private static final String XSS_SAFE_CONFIG_PROPERTY
= "UiBinder.useSafeHtmlTemplates";
private static final String LAZY_WIDGET_BUILDERS_PROPERTY
= "UiBinder.useLazyWidgetBuilders";
+
+ private static boolean gaveSafeHtmlWarning;
/**
* Given a UiBinder interface, return the path to its ui.xml file,
suitable
@@ -214,10 +216,11 @@
Boolean rtn = extractConfigProperty(
logger, propertyOracle, XSS_SAFE_CONFIG_PROPERTY, true);
- if (!rtn) {
+ if (!gaveSafeHtmlWarning && !rtn) {
logger.warn("Configuration property %s is false! UiBinder SafeHtml
integration is off, "
+ "leaving your users more vulnerable to cross-site scripting
attacks.",
XSS_SAFE_CONFIG_PROPERTY);
+ gaveSafeHtmlWarning = true;
}
return rtn;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
