Reviewers: tobyr,
Description:
Minor refactoring of "dashboard" interfaces in GWT. I'd made these
changes this week in another branch (while initial changes were still in
review) to make the implementation and some of its tests (which are
easier to write when method parameters are interfaces that can easily be
mocked vs. classes) a little cleaner.
DashboardNotifier interface uses new interfaces for DevModeEvent and
DevModeSession.
Previous DevModeSession (com.google.gwt.dev.shell) renamed to
BrowserChannelSession and implements the DevModeSession interface.
SpeedTracerLogger.Event now implements the DevModeEvent interface.
Please review this at http://gwt-code-reviews.appspot.com/1439801/
Affected files:
M dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
A dev/core/src/com/google/gwt/dev/shell/BrowserChannelSession.java
D dev/core/src/com/google/gwt/dev/shell/DevModeSession.java
M dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
M
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifier.java
A dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeEvent.java
A dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java
M
dev/core/src/com/google/gwt/dev/util/log/dashboard/NoOpDashboardNotifier.java
M
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
M dev/core/test/com/google/gwt/dev/shell/BrowserChannelServerTest.java
A dev/core/test/com/google/gwt/dev/shell/BrowserChannelSessionTest.java
A
dev/core/test/com/google/gwt/dev/shell/BrowserChannelSessionTestUtil.java
D dev/core/test/com/google/gwt/dev/shell/DevModeSessionTest.java
D dev/core/test/com/google/gwt/dev/shell/DevModeSessionTestUtil.java
M
dev/core/test/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactoryTest.java
M
dev/core/test/com/google/gwt/dev/util/log/dashboard/SpeedTracerLoggerTestMockNotifier.java
M
dev/core/test/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLoggerTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
