Reviewers: jat, Frank,

Description:
Disabling test for null on getBrowserById for DOM elements without DTD
when running on Chrome 12


Please review this at http://gwt-code-reviews.appspot.com/1443801/

Affected files:
  M user/test/com/google/gwt/xml/client/XMLTest.java


Index: user/test/com/google/gwt/xml/client/XMLTest.java
===================================================================
--- user/test/com/google/gwt/xml/client/XMLTest.java    (revision 9869)
+++ user/test/com/google/gwt/xml/client/XMLTest.java    (working copy)
@@ -217,8 +217,8 @@

     // we didn't define a dtd, so no id for us
     Element e1NodeDirect = d.getElementById("e1Id");
-    // Chrome 11 fails to implement this behavior
-    if (!Window.Navigator.getUserAgent().contains("Chrome/11.")) {
+    // Chrome 11 and 12 fail to implement this behavior
+    if (!Window.Navigator.getUserAgent().matches(".*Chrome/1[12]\\..*")) {
       assertNull(e1NodeDirect);
     }



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to