Mostly nits.

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java#newcode71
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:71:
public String getStyleName() {
Checkstyle error. This should go after getColumns(). Probably makes
smoke test fail.

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java#newcode172
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:172:
String styleName = cell.consumeStringAttribute(STYLE_NAME_ATTRIBUTE,
null);
Avoid repeating code. Can you move this outside the if?

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java#newcode179
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:179:
String styleName = cell.consumeStringAttribute(STYLE_NAME_ATTRIBUTE,
null);
See previous note

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/user/client/ui/Grid.java
File user/src/com/google/gwt/user/client/ui/Grid.java (right):

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/user/client/ui/Grid.java#newcode48
user/src/com/google/gwt/user/client/ui/Grid.java:48: *  <g:row
styleName="headerStyle">
These could confuse users into thinking the styleName is mandatory.
Perhaps name these "optionalHeaderStyle" and such, or explicitly mention
it in the preceding text.

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java
File
user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java
(right):

http://gwt-code-reviews.appspot.com/1441802/diff/1/user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java#newcode26
user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java:26:

Whitespace

http://gwt-code-reviews.appspot.com/1441802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to