LGTM On Thu, May 12, 2011 at 4:25 PM, <[email protected]> wrote:
> Reviewers: rjrjr, > > Description: > Fix checkstyle 'info' warnings > > > Please review this at http://gwt-code-reviews.appspot.com/1446803/ > > Affected files: > M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java > M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java > M dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java > M user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java > M user/src/com/google/gwt/event/dom/client/EndedEvent.java > M user/src/com/google/gwt/event/dom/client/ProgressEvent.java > M user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java > M user/src/com/google/gwt/event/shared/EventBus.java > M user/src/com/google/gwt/event/shared/ResettableEventBus.java > M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java > M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java > M user/src/com/google/web/bindery/autobean/shared/Splittable.java > M user/src/com/google/web/bindery/event/shared/ResettableEventBus.java > M user/src/com/google/web/bindery/requestfactory/shared/Receiver.java > M user/test/com/google/gwt/event/shared/SimpleEventBusTest.java > M user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java > M user/test/com/google/gwt/user/tools/WebAppCreatorTest.java > M > user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java > > > Index: dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java > =================================================================== > --- dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java > (revision 10178) > +++ dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java > (working copy) > @@ -135,8 +135,7 @@ > } > } > } > - > - > + > String[] cacheExtraFiles = getCacheExtraFiles(); > for (int i = 0; i < cacheExtraFiles.length; i++) { > staticResoucesSb.append(cacheExtraFiles[i]); > Index: > dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java > =================================================================== > --- dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java > (revision 10178) > +++ dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java > (working copy) > @@ -53,8 +53,6 @@ > * > * @param logger logger for logging errors to the console > * @param missingType The qualified source name of the type to report > - * @param unitMap if available, pass > - * {@link CompilationState#getCompilationUnitMap()}. > */ > public static void logMissingTypeErrorWithHints(TreeLogger logger, String > missingType, > CompilationState compilationState) { > @@ -105,7 +103,7 @@ > * originated. > * @param isError <code>true</code> if this is considered a fatal > compilation > * error. > - * @param supressErrors Controls the log level for logging errors. See > + * @param suppressErrors Controls the log level for logging errors. See > * {@link #reportErrors(TreeLogger, CompilationUnit, boolean)}. > * @return a branch of the logger parameter for logging further problems. > */ > @@ -174,7 +172,7 @@ > * > * @param logger logger for reporting errors to the console > * @param unit Compilation unit that may have errors > - * @param supressErrors Controls he log level for logging errors. If > + * @param suppressErrors Controls he log level for logging errors. If > * <code>false</code> is passed, compilation errors are logged > at > * TreeLogger.ERROR and warnings logged at TreeLogger.WARN. If > * <code>true</code> is passed, compilation errors are logged at > Index: > dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java > =================================================================== > --- dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java > (revision 10178) > +++ dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java > (working copy) > @@ -16,7 +16,6 @@ > package com.google.gwt.dev.javac; > > import com.google.gwt.core.ext.TreeLogger; > - > > import java.util.Collection; > import java.util.HashSet; > Index: user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java > =================================================================== > --- user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java > (revision 10178) > +++ user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java > (working copy) > @@ -56,7 +56,6 @@ > return TYPE; > } > > - > @Override > protected void dispatch(CanPlayThroughHandler handler) { > handler.onCanPlayThrough(this); > Index: user/src/com/google/gwt/event/dom/client/EndedEvent.java > =================================================================== > --- user/src/com/google/gwt/event/dom/client/EndedEvent.java (revision > 10178) > +++ user/src/com/google/gwt/event/dom/client/EndedEvent.java (working > copy) > @@ -55,7 +55,6 @@ > return TYPE; > } > > - > @Override > protected void dispatch(EndedHandler handler) { > handler.onEnded(this); > Index: user/src/com/google/gwt/event/dom/client/ProgressEvent.java > =================================================================== > --- user/src/com/google/gwt/event/dom/client/ProgressEvent.java (revision > 10178) > +++ user/src/com/google/gwt/event/dom/client/ProgressEvent.java (working > copy) > @@ -55,7 +55,6 @@ > return TYPE; > } > > - > @Override > protected void dispatch(ProgressHandler handler) { > handler.onProgress(this); > Index: user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java > =================================================================== > --- user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java > (revision 10178) > +++ user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java > (working copy) > @@ -34,7 +34,7 @@ > /** > * Returns whether or not the receiver is attached to the > * {@link com.google.gwt.dom.client.Document Document}'s > - * {@link com.google.gwt.dom.client.BodyElement BodyElement} > + * {@link com.google.gwt.dom.client.BodyElement BodyElement}. > * > * @return true if attached, false otherwise > */ > Index: user/src/com/google/gwt/event/shared/EventBus.java > =================================================================== > --- user/src/com/google/gwt/event/shared/EventBus.java (revision 10178) > +++ user/src/com/google/gwt/event/shared/EventBus.java (working copy) > @@ -53,7 +53,6 @@ > > public abstract void fireEvent(GwtEvent<?> event); > > - > @Override > public void fireEventFromSource(Event<?> event, Object source) { > throw new UnsupportedOperationException("Subclass responsibility. " > Index: user/src/com/google/gwt/event/shared/ResettableEventBus.java > =================================================================== > --- user/src/com/google/gwt/event/shared/ResettableEventBus.java > (revision 10178) > +++ user/src/com/google/gwt/event/shared/ResettableEventBus.java > (working copy) > @@ -89,7 +89,7 @@ > } > > /** > - * Visible for testing > + * Visible for testing. > */ > int getRegistrationSize() { > return real.getRegistrationSize(); > Index: user/src/com/google/gwt/resources/rg/CssResourceGenerator.java > =================================================================== > --- user/src/com/google/gwt/resources/rg/CssResourceGenerator.java > (revision 10178) > +++ user/src/com/google/gwt/resources/rg/CssResourceGenerator.java > (working copy) > @@ -631,7 +631,6 @@ > } > } > > - > /** > * Determine the class prefix that will be used. If a value is > automatically > * computed, the <code>reservedPrefixes</code> set will be cleared > because the > Index: user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java > =================================================================== > --- user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java > (revision 10178) > +++ user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java > (working copy) > @@ -99,7 +99,6 @@ > add(widget, getElement()); > } > > - > /** > * Adds a child widget to the panel, replacing the HTML element. > * > Index: user/src/com/google/web/bindery/autobean/shared/Splittable.java > =================================================================== > --- user/src/com/google/web/bindery/autobean/shared/Splittable.java > (revision 10178) > +++ user/src/com/google/web/bindery/autobean/shared/Splittable.java > (working copy) > @@ -31,7 +31,7 @@ > Splittable NULL = StringQuoter.nullValue(); > > /** > - * Returns a boolean representation of the data; > + * Returns a boolean representation of the data. > */ > boolean asBoolean(); > > Index: user/src/com/google/web/bindery/event/shared/ResettableEventBus.java > =================================================================== > --- user/src/com/google/web/bindery/event/shared/ResettableEventBus.java > (revision 10178) > +++ user/src/com/google/web/bindery/event/shared/ResettableEventBus.java > (working copy) > @@ -74,7 +74,7 @@ > } > > /** > - * Visible for testing > + * Visible for testing. > */ > protected int getRegistrationSize() { > return registrations.size(); > Index: user/src/com/google/web/bindery/requestfactory/shared/Receiver.java > =================================================================== > --- user/src/com/google/web/bindery/requestfactory/shared/Receiver.java > (revision 10178) > +++ user/src/com/google/web/bindery/requestfactory/shared/Receiver.java > (working copy) > @@ -73,7 +73,7 @@ > * {@link ConstraintViolation} objects to the deprecated {@link > Violation} > * type. > * > - * @param errors a Set of {@link ConstraintViolation} instances > + * @param violations a Set of {@link ConstraintViolation} instances > */ > @SuppressWarnings("deprecation") > public void onConstraintViolation(Set<ConstraintViolation<?>> violations) > { > Index: user/test/com/google/gwt/event/shared/SimpleEventBusTest.java > =================================================================== > --- user/test/com/google/gwt/event/shared/SimpleEventBusTest.java > (revision 10178) > +++ user/test/com/google/gwt/event/shared/SimpleEventBusTest.java > (working copy) > @@ -230,7 +230,6 @@ > assertNotFired(two); > } > > - > static class ThrowingHandler implements MouseDownHandler { > private final RuntimeException e; > > Index: user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java > =================================================================== > --- user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java (revision > 10178) > +++ user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java (working > copy) > @@ -112,7 +112,7 @@ > } > > /** > - * Mock selection property; > + * Mock selection property. > */ > private static class MockSelectionProperty implements SelectionProperty { > > Index: user/test/com/google/gwt/user/tools/WebAppCreatorTest.java > =================================================================== > --- user/test/com/google/gwt/user/tools/WebAppCreatorTest.java (revision > 10178) > +++ user/test/com/google/gwt/user/tools/WebAppCreatorTest.java (working > copy) > @@ -267,7 +267,7 @@ > } > > /** > - * Generate a .classpath containing a .jar in war/WEB-INF/lib > + * Generate a .classpath containing a .jar in war/WEB-INF/lib. > */ > public void testCreatorOnlyEclipseWithJars() throws IOException, > WebAppCreatorException { > runCreator("-out", projectFolder, "-XnoEclipse", "-junit", mockJar, > Index: > user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java > =================================================================== > --- > user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java > (revision 10178) > +++ > user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java > (working copy) > @@ -20,7 +20,7 @@ > import junit.framework.TestCase; > > /** > - * Tests creating of ServiceLocators with custom ServiceLayerDecorators > + * Tests creating of ServiceLocators with custom ServiceLayerDecorators. > */ > public class ServiceLocatorTest extends TestCase { > > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
