Yes please, we shouldn't have broken existing code like that. On Tue, May 17, 2011 at 3:25 PM, Stephen Haberman < [email protected]> wrote:
> Hi, > > With the bindery package change, I have a custom EventBus implementation > that no longer compiles. I was calling GwtEvent.setSource (and squatting > in the c.g.g.e.shared package to do so), but now setSource is defined in > the bindery package and so inaccessible. > > I can move my EventBus to the new bindery package and squat there, but > it makes it complicated supporting both pre-2.4 and post-2.4 codebases. > > If possible, adding a GwtEvent.setSource that restored the old > visibility would be preferable. I have a simple patch to do so if that's > okay. > > At some point it would be nice to be able to implement an EventBus > without squatting in a c.g package, though I understand the appeal of > keeping the "not for user code" methods protected. > > - Stephen > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
