[gwt-contrib] Previous change to compiler report formatting switched to NumberFormat to format deciamls, but b... (issue1443803)

Wed, 18 May 2011 15:22:54 -0700 

Reviewers: zundel,

Description:
Previous change to compiler report formatting switched to NumberFormat
to format deciamls, but broke the report's "Bytes" bar graphs, which
were off by a factor of 100 (displaying 0.282% instead of 28.2%).


Please review this at http://gwt-code-reviews.appspot.com/1443803/

Affected files:
  M dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java


Index: dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
===================================================================
--- dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (revision 10192) +++ dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (working copy) 
@@ -714,7 +714,7 @@
           outFile.println("<td class=\"soyc-bargraph-col\">");
outFile.println("<div class=\"soyc-bar-graph goog-inline-block\">"); 
           // CHECKSTYLE_OFF
-          outFile.println("<div style=\"width:" + perc
+          outFile.println("<div style=\"width:" + (perc * 100.0)
+ "%;\" class=\"soyc-bar-graph-fill goog-inline-block\"></div>"); 
           // CHECKSTYLE_ON
           outFile.println("</div>");
@@ -1064,7 +1064,7 @@
             outFile.println("<td class=\"soyc-bargraph-col\">");
outFile.println("<div class=\"soyc-bar-graph goog-inline-block\">"); 
             // CHECKSTYLE_OFF
-            outFile.println("<div style=\"width:" + perc
+            outFile.println("<div style=\"width:" + (perc * 100.0)
+ "%;\" class=\"soyc-bar-graph-fill goog-inline-block\"></div>"); 
             // CHECKSTYLE_ON
             outFile.println("</div>");
@@ -1235,7 +1235,7 @@
         outFile.println("<td class=\"soyc-bargraph-col\">");
outFile.println("<div class=\"soyc-bar-graph goog-inline-block\">"); 
         // CHECKSTYLE_OFF
-        outFile.println("<div style=\"width:" + perc
+        outFile.println("<div style=\"width:" + (perc * 100.0)
+ "%;\" class=\"soyc-bar-graph-fill goog-inline-block\"></div>"); 
         // CHECKSTYLE_ON
         outFile.println("</div>");
@@ -1437,7 +1437,7 @@
         outFile.println("<td class=\"soyc-bargraph-col\">");
outFile.println("<div class=\"soyc-bar-graph goog-inline-block\">"); 
         // CHECKSTYLE_OFF
-        outFile.println("<div style=\"width:" + perc
+        outFile.println("<div style=\"width:" + (perc * 100.0)
+ "%;\" class=\"soyc-bar-graph-fill goog-inline-block\"></div>"); 
         // CHECKSTYLE_ON
         outFile.println("</div>");
@@ -1753,7 +1753,7 @@
         outFile.println("<td class=\"soyc-bargraph-col\">");
outFile.println("<div class=\"soyc-bar-graph goog-inline-block\">"); 
         // CHECKSTYLE_OFF
-        outFile.println("<div style=\"width:" + perc
+        outFile.println("<div style=\"width:" + (perc * 100.0)
+ "%;\" class=\"soyc-bar-graph-fill goog-inline-block\"></div>"); 
         // CHECKSTYLE_ON
         outFile.println("</div>");
@@ -1789,4 +1789,4 @@
   private String splitStatusFileName() {
     return "splitStatus-" + getPermutationId() + ".html";
   }
-}
\ No newline at end of file
+}


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to