Revision: 10207
Author:   [email protected]
Date:     Tue May 24 03:58:52 2011
Log: Add the method name to the message of InvocationService to make it easier to
find out the rootcause of the exception.

Review at http://gwt-code-reviews.appspot.com/1450803

Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=10207

Modified:
 /trunk/user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java
 /trunk/user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/RequestCallbackAdapter.java

=======================================
--- /trunk/user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java Mon Sep 20 10:54:28 2010 +++ /trunk/user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java Tue May 24 03:58:52 2011
@@ -83,7 +83,7 @@
         caught = new StatusCodeException(statusCode, encodedResponse);
       } else if (encodedResponse == null) {
         // This can happen if the XHR is interrupted by the server dying
-        caught = new InvocationException("No response payload");
+ caught = new InvocationException("No response payload from " + methodName);
       } else {
result = (T) streamFactory.createStreamReader(encodedResponse).readObject();
       }
=======================================
--- /trunk/user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java Tue Apr 26 07:33:38 2011 +++ /trunk/user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java Tue May 24 03:58:52 2011
@@ -372,7 +372,8 @@
       return rb.send();
     } catch (RequestException ex) {
       InvocationException iex = new InvocationException(
- "Unable to initiate the asynchronous service invocation -- check the network connection",
+          "Unable to initiate the asynchronous service invocation (" +
+          methodName + ") -- check the network connection",
           ex);
       callback.onFailure(iex);
     } finally {
=======================================
--- /trunk/user/src/com/google/gwt/user/client/rpc/impl/RequestCallbackAdapter.java Tue Nov 23 13:47:33 2010 +++ /trunk/user/src/com/google/gwt/user/client/rpc/impl/RequestCallbackAdapter.java Tue May 24 03:58:52 2011
@@ -209,13 +209,13 @@
         caught = new StatusCodeException(statusCode, encodedResponse);
       } else if (encodedResponse == null) {
         // This can happen if the XHR is interrupted by the server dying
-        caught = new InvocationException("No response payload");
+ caught = new InvocationException("No response payload from " + methodName);
       } else if (RemoteServiceProxy.isReturnValue(encodedResponse)) {
result = (T) responseReader.read(streamFactory.createStreamReader(encodedResponse));
       } else if (RemoteServiceProxy.isThrownException(encodedResponse)) {
caught = (Throwable) streamFactory.createStreamReader(encodedResponse).readObject();
       } else {
-        caught = new InvocationException(encodedResponse);
+ caught = new InvocationException(encodedResponse + " from " + methodName);
       }
     } catch (com.google.gwt.user.client.rpc.SerializationException e) {
       caught = new IncompatibleRemoteServiceException(

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to