Sweet.

http://gwt-code-reviews.appspot.com/1449804/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java
(right):

http://gwt-code-reviews.appspot.com/1449804/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java#newcode35
user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java:35:
* public class MyBatchedRequestScope extends
BatchedRequestScope<MyRequestFactory, MyRequestContext> {
Scope has a specific meaning to Gin users, would be good to avoid the
term here. s/BatchedRequestScope/RequestBatch/?

http://gwt-code-reviews.appspot.com/1449804/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java#newcode52
user/src/com/google/web/bindery/requestfactory/gwt/client/BatchedRequestScope.java:52:
* Request.to(Receiver)} as shown:
Fragile. Could put a guard on fire that makes it a synonym for to? The
finally call could raise the guard and make the real fire call.

http://gwt-code-reviews.appspot.com/1449804/diff/1/user/src/com/google/web/bindery/requestfactory/shared/FanoutReceiver.java
File
user/src/com/google/web/bindery/requestfactory/shared/FanoutReceiver.java
(right):

http://gwt-code-reviews.appspot.com/1449804/diff/1/user/src/com/google/web/bindery/requestfactory/shared/FanoutReceiver.java#newcode34
user/src/com/google/web/bindery/requestfactory/shared/FanoutReceiver.java:34:
public class FanoutReceiver<T> extends Receiver<T> {
be easy to unit test this

http://gwt-code-reviews.appspot.com/1449804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to