Rolled back at r10213 On 2011/05/24 15:31:52, rchandia wrote:
Submitted as of r10210
On 2011/05/23 20:00:39, rjrjr wrote: > LGTM > > Woot! > >
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
> File
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
> (right): > >
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java#newcode80
>
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java:80:
> "fieldName.setHTML(\"@mockToken-fieldName-Hello, I
<b>caption</b>you.\");",
> Absolutely, and sorry for the mess. > > On 2011/05/23 19:52:21, rchandia wrote: > > On 2011/05/23 18:25:23, rjrjr wrote: > > > is the "fieldName" string coming from a constant in
ElementParserTester or
> > > something? If so, can you open up its visibility and use it in
these
tests, > > > rather having it inlined all over the place? > > > > Done for the lines changed in this Issue. > > > > The string comes from ElementParserTester#FIELD_NAME. It is
hard-coded all
> over > > the place, though (at least 45/278 tests in UiBinderJreSuite). > > > > May I finish surfacing it in a separate Issue?
http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
