http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right):
http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode1050 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1050: (sourceInfoMaps != null) ? ((JsReportGenerationVisitor)v).getSourceInfoMap() : null; See what you can do to get rid of this cast. It works, but is not so elegant. You could add a method getSourceInfoMap on JsSourceGenerationWithSizeBreakdown() that returns null and let JsReportGenerationVisitor override it. http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode1062 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1062: code = clusterer.getJs(); I am still tending toward adding a general 'runXfomrer' method on JsSourceGenerationVisitorWithSizeBreakdown() or what about this: JsAbstractTextTransformer transformer = new JsAbstractTextTransfomer (code, statementRanges, infoMap) { public void exec() {} }; if (should_cluster) { lastTransfomer = new JsJsFunctionClusterer(); transformer.exec() } if (splitBlocks) { transfomer = new JsIeBlockTextTransformer(...); transformer.exec() } js[i] = transfomer.getJs() ranges[i] =transfoemr.getStatementRanges() ... http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode1324 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1324: remove w/s http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/impl/JsAbstractTextTransformer.java File dev/core/src/com/google/gwt/dev/jjs/impl/JsAbstractTextTransformer.java (right): http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/impl/JsAbstractTextTransformer.java#newcode94 dev/core/src/com/google/gwt/dev/jjs/impl/JsAbstractTextTransformer.java:94: * @param index TODO no time like the present... http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java (right): http://gwt-code-reviews.appspot.com/1451801/diff/1005/dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java#newcode175 dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:175: @Override can you provide a 1-3 sentence overview of what this method is for. http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
