Reviewers: rjrjr,
Message:
I don't think RequestFactory.find() should be deprecated. It's a
convenient starting point. If you want to convert existing calls to
find() to operate in a chained manner, the Request.to() method returns
the underlying RequestContext, which will now have its own find()
method.
http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java
File
user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java
(left):
http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java#oldcode30
user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java:30:
public interface FindRequest extends RequestContext {
This type hasn't been used for a while.
http://gwt-code-reviews.appspot.com/1448806/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java
(right):
http://gwt-code-reviews.appspot.com/1448806/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java#newcode55
user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java:55:
public void testChainedFind() {
The addition of this method is the only real change, the rest is
reformatting.
Description:
Add RequestContext.find() to support chained requests.
Delete unused FindRequest type.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1448806/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java
M
user/src/com/google/web/bindery/requestfactory/shared/RequestFactory.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestFactory.java
D
user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java
M
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
