LGTM

On Wed, May 25, 2011 at 11:53 AM, <[email protected]> wrote:

> Reviewers: rjrjr,
>
> Description:
> Fix escaping issue with SafeHtml in Safari3
>
> Review by: [email protected]
>
> Please review this at http://gwt-code-reviews.appspot.com/1443806/
>
> Affected files:
>  M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
>
>
> Index: user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
> ===================================================================
> --- user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
> (revision 10224)
> +++ user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
> (working copy)
> @@ -631,8 +631,8 @@
>   public void testUiTextWithSafeHtml() {
>     assertEquals(widgetUi.htmlWithComputedSafeHtml.getHTML().toLowerCase(),
>         "<b>this text should be bold!</b>");
> -    assertEquals(widgetUi.htmlWithComputedText.getHTML().toLowerCase(),
> -        "&lt;b&gt;this text won't be bold!&lt;/b&gt;");
> +    assertEquals(widgetUi.htmlWithComputedText.getHTML().toLowerCase()
> +        .replaceAll(">", "&gt;"), "&lt;b&gt;this text won't be
> bold!&lt;/b&gt;");
>     assertEquals(widgetUi.labelWithComputedText.getText().toLowerCase(),
>         "<b>this text won't be bold!</b>");
>   }
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to