Reviewers: jbrosenberg, zundel,

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java
File dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java (right):

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java#newcode89
dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java:89: }
These will be needed for AST stitching, which is what prompted this
refactor.  But I think the result is a lot simpler.

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/FixAssignmentToUnbox.java
File dev/core/src/com/google/gwt/dev/jjs/impl/FixAssignmentToUnbox.java
(right):

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/FixAssignmentToUnbox.java#newcode121
dev/core/src/com/google/gwt/dev/jjs/impl/FixAssignmentToUnbox.java:121:
autoboxUtils.box(x.getRhs(), (JPrimitiveType) lhs.getType())));
AutoBoxUtils had two overloads, one that expected you to pass 'Integer'
ReferenceType, the other 'int' PrimitiveType.  I got rid of the first
overload as the second was simpler and it turns out I had the correct
type readily available.



Please review this at http://gwt-code-reviews.appspot.com/1443808/

Affected files:
  M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/FixAssignmentToUnbox.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to