http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java
File dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java (right):

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java#newcode47
dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java:47: for
(JMethod method : wrapperType.getMethods()) {
move initialization of boxSig & unboxSig before the start of the for
loop.

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java#newcode97
dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java:97:
JMethodCall argMethodCall = (JMethodCall) arg;
How do we know the only possible methodCall that could be passed here
will be an unboxMethod()?  Is that the only methodCall type that can be
the lhs of a binaray assignment (e.g. looking at the call-site in
FixAssignmentToUnbox).
It looks like there are other call-sites with less guaranteed
semantics...

http://gwt-code-reviews.appspot.com/1443808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to