LGTM
http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java (right): http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java#newcode19 user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java:19: * The base interface for RequestFactory service endpoints. Add disclaimer explaining that this interface (and the others) are normally implemented by generated code, and are subject to incompatible updates? And should log an item on the issue tracker with the appropriate breaking change label. http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode528 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:528: new Object[] {proxyId}, propertyRefs, proxyId.getProxyClass(), null); Ha! Do you have other sneaky literals like this lying around? http://gwt-code-reviews.appspot.com/1448806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
