[gwt-contrib] Fix warnings in samples/expenses (issue1447810)

Fri, 27 May 2011 11:00:19 -0700 

Reviewers: jlabanca,

Description:
Fix warnings in samples/expenses


Please review this at http://gwt-code-reviews.appspot.com/1447810/

Affected files:
  M samples/expenses/pom.xml
M samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java M samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java 


Index: samples/expenses/pom.xml
===================================================================
--- samples/expenses/pom.xml    (revision 10237)
+++ samples/expenses/pom.xml    (working copy)
@@ -11,8 +11,8 @@
     <roo.version>1.1.0.RELEASE</roo.version>
     <spring.version>3.0.3.RELEASE</spring.version>
     <slf4j.version>1.6.1</slf4j.version>
-    <gae.version>1.5.0</gae.version>
-    <gae-test.version>1.5.0</gae-test.version>
+    <gae.version>1.5.0.1</gae.version>
+    <gae-test.version>1.5.0.1</gae-test.version>
<gae.home>${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}</gae.home> 
     <datanucleus.version>1.1.5</datanucleus.version>
   </properties>
Index: samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java (working copy) 
@@ -415,12 +415,10 @@
       scrollOffTimer.schedule(100);
     }

-    boolean firstDrag = false;
     if (!dragging) {
       if (totalMoveY > MIN_TRACKING_FOR_DRAG
           || totalMoveX > MIN_TRACKING_FOR_DRAG) {
         dragging = true;
-        firstDrag = true;
         dragDelegate.onDragStart(e);
       }
     }
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java (working copy) 
@@ -42,7 +42,6 @@
 import com.google.gwt.i18n.client.NumberFormat;
 import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.safehtml.shared.SafeHtmlUtils;
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java (working copy) 
@@ -22,7 +22,6 @@
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.Style.Overflow;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.sample.expenses.client.style.Styles;
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java (working copy) 
@@ -18,7 +18,6 @@
 import com.google.gwt.cell.client.AbstractCell;
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.sample.expenses.shared.ExpenseProxy;
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java (working copy) 
@@ -59,12 +59,12 @@

     @Override
     protected T getDisplayedItem(int index) {
-      return cellList.getDisplayedItem(index);
+      return cellList.getVisibleItem(index);
     }

     @Override
     protected List<T> getDisplayedItems() {
-      return cellList.getDisplayedItems();
+      return cellList.getVisibleItems();
     }

     @Override
@@ -97,12 +97,12 @@

     @Override
     protected T getDisplayedItem(int index) {
-      return cellTable.getDisplayedItem(index);
+      return cellTable.getVisibleItem(index);
     }

     @Override
     protected List<T> getDisplayedItems() {
-      return cellTable.getDisplayedItems();
+      return cellTable.getVisibleItems();
     }

     @Override
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java (working copy) 
@@ -90,6 +90,7 @@
    * Set the widget to show, adding it to the end of our sliding set if we
    * haven't seen it before. Nulls are ignored.
    */
+  @SuppressWarnings("deprecation")
   // Conflict btw deprecated Composite#setWidget and HasOneWidget#setWidget
   @Override
   public void setWidget(Widget widget) {
Index: samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java (working copy) 
@@ -47,7 +47,7 @@

   private static final Long ZERO = Long.valueOf(0L);

-  private static final boolean DENSE_IDS = false;
+//  private static final boolean DENSE_IDS = false;

   public static final EntityManager entityManager() {
     return EMF.get().createEntityManager();
@@ -167,10 +167,10 @@
             + mmin + " and id < " + mmax;
         Number count = (Number) em.createQuery(query).getSingleResult();
         long value = count.longValue();
-        if (value == 0 && DENSE_IDS) {
-          log.info("Got 0 results between " + mmin + " and " + mmax);
-          break;
-        }
+//        if (value == 0 && DENSE_IDS) {
+//          log.info("Got 0 results between " + mmin + " and " + mmax);
+//          break;
+//        }

         mmin = mmax;
         min = Long.valueOf(mmin);
Index: samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java 
===================================================================
--- samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java (revision 10237) +++ samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java (working copy) 
@@ -20,7 +20,6 @@
 import com.google.gwt.http.client.RequestCallback;
 import com.google.gwt.http.client.Response;
import com.google.web.bindery.requestfactory.gwt.client.DefaultRequestTransport; -import com.google.web.bindery.requestfactory.shared.RequestTransport.TransportReceiver; 
 import com.google.web.bindery.requestfactory.shared.ServerFailure;

 /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to