http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java#newcode38 dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:38: boolean checkRebindRuleAvailable(String typeName); On 2011/05/27 13:39:20, scottb wrote:
"sourceTypeName" if that's what it is (e.g. "com.example.Foo.Bar" vs. "com.example.Foo$Bar"
Done. Here and elsewhere that it's implemented. http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java File dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java (right): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java#newcode22 dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java:22: boolean checkRebindRuleResolvable(String typeName); Well, I guess I don't want to expose the full RebindOracle interface to the StandardGeneratorContext (e.g. generators shouldn't be able to call rebind() directly). Also, other things implement the RebindOracle interface, such as ModuleSpaceHost (and by extension ShellModuleSpaceHost). It doesn't seem sensible for those to implement checkRebindRuleResolvable(), etc. No? http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java (left): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java#oldcode109 dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:109: usedTypeNames.add(typeName); I haven't been able to break things with setting up circular dependencies. Seems to be passing all the tests I've tried with it, etc. http://gwt-code-reviews.appspot.com/1450806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
