[gwt-contrib] Re: Consolidates all methodDependencies files into one per split point. (issue1453802)

[dconnelly]

LGTM

On 2011/05/31 16:05:05, zundel wrote:

http://gwt-code-reviews.appspot.com/1453802/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java

File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java

(right):


http://gwt-code-reviews.appspot.com/1453802/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java#newcode1708

dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:1708:

boolean

first = true;
On 2011/05/31 15:01:15, dconnelly wrote:
> what is this for? I don't see another reference to "first". Is it to

replace

the
> if (method != classisInSplitPoint.get(0)) below?

yes, I had a problem resolving and this is cruft I left behind.  Let

me send you

a cleanup patch.

http://gwt-code-reviews.appspot.com/1453802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors