LGTM
w/nits

http://gwt-code-reviews.appspot.com/1447814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MethodCallTightener.java
File dev/core/src/com/google/gwt/dev/jjs/impl/MethodCallTightener.java
(right):

http://gwt-code-reviews.appspot.com/1447814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MethodCallTightener.java#newcode40
dev/core/src/com/google/gwt/dev/jjs/impl/MethodCallTightener.java:40: *
Add the usual javadoc tags here for the indenting/code, etc., e.g. use
<pre>{@code...}...</pre>

http://gwt-code-reviews.appspot.com/1447814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java
File dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java
(right):

http://gwt-code-reviews.appspot.com/1447814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java#newcode77
dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java:77: *
use the javadoc tags here for code:  <pre>{@code.....}</pre>

http://gwt-code-reviews.appspot.com/1447814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java#newcode80
dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java:80: * can be
tightened from List to ArrayList because no type other than ArrayList
s/can ever assigned/can ever be assigned

http://gwt-code-reviews.appspot.com/1447814/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to