http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/ast/JRunAsync.java File dev/core/src/com/google/gwt/dev/jjs/ast/JRunAsync.java (right):
http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/ast/JRunAsync.java#newcode98 dev/core/src/com/google/gwt/dev/jjs/ast/JRunAsync.java:98: * Explcitly traverse the onSuccessCall. On 2011/06/02 16:36:44, zundel wrote:
This comment doesn't really tell us much more than the code itself.
The bug
that led to this code was tricky - maybe add a bit more explanation?
The method is general-purpose tho, any optimizer might do it. Are you saying I should just remove the doc? http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java (right): http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode371 dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:371: * Magic magic magic: don't allow code flow from the AsyncFragmentLoader On 2011/06/02 16:36:44, zundel wrote:
(again, not magic...)
PFM, baby. http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java (right): http://gwt-code-reviews.appspot.com/1442807/diff/6025/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java#newcode66 dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java:66: * Magic magic magic: don't optimizations on the calls from from Will fix the comment. It's magic in the sense that there's a subtle and specific hack in a specific optimizer to violate what that optimizer would ordinary do, for some higher purpose of which the optimizer knows not. From the optimizer's point of view, it's pure magic. To the extent that this jumps out at you as something crazy and possibly wrong-- that's what's it's SUPPOSED to do. :) http://gwt-code-reviews.appspot.com/1442807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
