Reviewers: rchandia,

Description:
Make private two new methods accidentally exposed in ActivityManager


Please review this at http://gwt-code-reviews.appspot.com/1449811/

Affected files:
  M user/src/com/google/gwt/activity/shared/ActivityManager.java


Index: user/src/com/google/gwt/activity/shared/ActivityManager.java
===================================================================
--- user/src/com/google/gwt/activity/shared/ActivityManager.java (revision 10272) +++ user/src/com/google/gwt/activity/shared/ActivityManager.java (working copy)
@@ -181,7 +181,25 @@
     }
   }

-  public Throwable tryStart() {
+  private Activity getNextActivity(PlaceChangeEvent event) {
+    if (display == null) {
+      /*
+ * Display may have been nulled during PlaceChangeEvent dispatch. Don't
+       * bother the mapper, just return a null to ensure we shut down the
+       * current activity
+       */
+      return null;
+    }
+    return mapper.getActivity(event.getNewPlace());
+  }
+
+  private void showWidget(IsWidget view) {
+    if (display != null) {
+      display.setWidget(view);
+    }
+  }
+
+  private Throwable tryStart() {
     Throwable caughtOnStart = null;
     try {
       /* Wrap the actual display with a per-call instance
@@ -196,7 +214,7 @@
     return caughtOnStart;
   }

-  public Throwable tryStopOrCancel(boolean stop) {
+  private Throwable tryStopOrCancel(boolean stop) {
     Throwable caughtOnStop = null;
     try {
       if (stop) {
@@ -214,24 +232,6 @@
       stopperedEventBus.removeHandlers();
     }
     return caughtOnStop;
-  }
-
-  private Activity getNextActivity(PlaceChangeEvent event) {
-    if (display == null) {
-      /*
- * Display may have been nulled during PlaceChangeEvent dispatch. Don't
-       * bother the mapper, just return a null to ensure we shut down the
-       * current activity
-       */
-      return null;
-    }
-    return mapper.getActivity(event.getNewPlace());
-  }
-
-  private void showWidget(IsWidget view) {
-    if (display != null) {
-      display.setWidget(view);
-    }
   }

   private void updateHandlers(boolean activate) {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to