http://gwt-code-reviews.appspot.com/1449814/diff/1/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java File user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java (right):
http://gwt-code-reviews.appspot.com/1449814/diff/1/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java#newcode117 user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java:117: if (Character.isHighSurrogate((char) codePoint) || Character.isLowSurrogate((char) codePoint)) { Long lines, here and below. http://gwt-code-reviews.appspot.com/1449814/diff/1/user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java File user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java (right): http://gwt-code-reviews.appspot.com/1449814/diff/1/user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java#newcode96 user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java:96: assertEquals(CONSTANT_URL, UriUtils.fromTrustedString(CONSTANT_URL).asString()); While you're here, could you change fromTrustedString to fromSafeConstant where the argument is a constant? In keeping with the desire that fromTrustedString should be used as little as possible... http://gwt-code-reviews.appspot.com/1449814/diff/1/user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java#newcode109 user/test/com/google/gwt/safehtml/shared/GwtUriUtilsTest.java:109: public void testFromTrustedString_withInvalidUrl() { Given that this test passed even with the original regex check commented out, would it make sense to to split the character set check of isValidUri out and test it separately? http://gwt-code-reviews.appspot.com/1449814/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
