Reviewers: fredsa,
Description:
Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol
map were being used in resymbolization only if the line number from
StackTraceElement is 0, where it should be used if the line number is
-1, per StackTraceElement's javadoc:
http://download.oracle.com/javase/6/docs/api/java/lang/StackTraceElement.html
Please review this at http://gwt-code-reviews.appspot.com/1457801/
Affected files:
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===================================================================
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(revision 10294)
+++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(working copy)
@@ -136,11 +136,11 @@
int lineNumber = ste.getLineNumber();
/*
- * When lineNumber is zero, either because compiler.stackMode is
not
+ * When lineNumber is -1, either because compiler.stackMode is not
* emulated or compiler.emulatedStack.recordLineNumbers is false,
use
* the method declaration line number from the symbol map.
*/
- if (lineNumber == 0) {
+ if (lineNumber == -1) {
lineNumber = Integer.parseInt(parts[4]);
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
