Revision: 10296
Author:   jbrosenb...@google.com
Date:     Wed Jun  8 10:02:34 2011
Log: Don't initialize SpeedTracerLogger thread or process time keepers if not enabled.

Review at http://gwt-code-reviews.appspot.com/1456801

Review by: jhumphr...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10296

Modified:
/trunk/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java

=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java Wed May 11 07:35:17 2011 +++ /trunk/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java Wed Jun 8 10:02:34 2011
@@ -113,7 +113,9 @@

     Event() {
       if (enabled) {
-        threadCpuTimeKeeper.resetTimeBase();
+        if (logThreadCpuTime) {
+          threadCpuTimeKeeper.resetTimeBase();
+        }
         recordStartTime();
         this.data = Lists.create();
         this.children = Lists.create();
@@ -702,10 +704,11 @@

private final ElapsedNormalizedTimeKeeper elapsedTimeKeeper = new ElapsedNormalizedTimeKeeper();

-  private final ProcessNormalizedTimeKeeper processCpuTimeKeeper =
-      new ProcessNormalizedTimeKeeper();
-
- private final ThreadNormalizedTimeKeeper threadCpuTimeKeeper = new ThreadNormalizedTimeKeeper();
+  private final ProcessNormalizedTimeKeeper processCpuTimeKeeper =
+ (logProcessCpuTime) ? new ProcessNormalizedTimeKeeper() : null;
+
+  private final ThreadNormalizedTimeKeeper threadCpuTimeKeeper =
+              (logThreadCpuTime) ? new ThreadNormalizedTimeKeeper() : null;

   /**
    * Constructor intended for unit testing.
@@ -899,9 +902,11 @@
     if (!threadPendingEvents.isEmpty()) {
       parent = threadPendingEvents.peek();
     } else {
- // reset the thread CPU time base for top-level events (so events can be
-      // properly sequenced chronologically)
-      threadCpuTimeKeeper.resetTimeBase();
+      if (logThreadCpuTime) {
+ // reset the thread CPU time base for top-level events (so events can be
+        // properly sequenced chronologically)
+        threadCpuTimeKeeper.resetTimeBase();
+      }
     }

     Event newEvent = new Event(session, parent, type, data);

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to