Hmm... it seems fairly reasonable, except for the part about having to
write an enormous amount of code to cover all of HTML. (If it weren't
client-side code, I'd go with a more concise API and do more checking at
runtime.)

I wonder if we should generate the code? (Not in a GWT generator, but as
part of the build process?)



http://gwt-code-reviews.appspot.com/1455802/diff/1/user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java
File user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java
(right):

http://gwt-code-reviews.appspot.com/1455802/diff/1/user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java#newcode48
user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java:48: T
appendText(String text);
Perhaps just "text" instead of "appendText"?

something.startDiv().text("Some text").endDiv();

http://gwt-code-reviews.appspot.com/1455802/diff/1/user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java
File
user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java
(right):

http://gwt-code-reviews.appspot.com/1455802/diff/1/user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java#newcode62
user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java:62:
public abstract DivElementBuilder createDivElementBuilder();
Hmm... I wonder if we should have another class with static methods to
kick this off?

Elements.startDiv().text("Hello!").endDiv().toSafeHtml();

http://gwt-code-reviews.appspot.com/1455802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to