[gwt-contrib] Re: Resolve PotentialElement children before inserting them into a container. (issue1454810)

[Ray Ryan]

LGTM

On Fri, Jun 10, 2011 at 10:29 AM, <jul...@google.com> wrote:

> Uploaded patch with assertion in DOM.insertListItem as patch set 3.
>
>
>
> http://gwt-code-reviews.**appspot.com/1454810/diff/3001/**
> user/src/com/google/gwt/user/**client/DOM.java<http://gwt-code-reviews.appspot.com/1454810/diff/3001/user/src/com/google/gwt/user/client/DOM.java>
> File user/src/com/google/gwt/user/**client/DOM.java (right):
>
> http://gwt-code-reviews.**appspot.com/1454810/diff/3001/**
> user/src/com/google/gwt/user/**client/DOM.java#newcode974<http://gwt-code-reviews.appspot.com/1454810/diff/3001/user/src/com/google/gwt/user/client/DOM.java#newcode974>
> user/src/com/google/gwt/user/**client/DOM.java:974: String value, int
> index) {
> On 2011/06/10 17:12:23, rjrjr wrote:
>
>> Seems like the assert line should be added here too.
>>
>
>   assert !PotentialElement.isPotential(**selectElem) : "Cannot insert
>>
> into a
>
>> PotentialElement";
>>
>
> Done.
>
>
> http://gwt-code-reviews.**appspot.com/1454810/<http://gwt-code-reviews.appspot.com/1454810/>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors