LGTM Wow. That was a lot less work than I expected.
Patch description is oddly restrictive, "polymorphic return values." You also support polymorphic arguments, right? http://gwt-code-reviews.appspot.com/1453811/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java File user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java (right): http://gwt-code-reviews.appspot.com/1453811/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java#newcode251 user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java:251: poison("Unable to find extra type %s in TypeOracle", clazz.getCanonicalName()); TypeOracle is an implementation detail, odd to see it called out in a user facing error message. How about "Unknown class %s in @ExtraTypes"? http://gwt-code-reviews.appspot.com/1453811/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java#newcode289 user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/RequestFactoryModel.java:289: builder.setSuperProxyTyes(superTypes); Tyes http://gwt-code-reviews.appspot.com/1453811/diff/1/user/test/com/google/web/bindery/requestfactory/server/RequestFactoryPolymorphicJreTest.java File user/test/com/google/web/bindery/requestfactory/server/RequestFactoryPolymorphicJreTest.java (right): http://gwt-code-reviews.appspot.com/1453811/diff/1/user/test/com/google/web/bindery/requestfactory/server/RequestFactoryPolymorphicJreTest.java#newcode62 user/test/com/google/web/bindery/requestfactory/server/RequestFactoryPolymorphicJreTest.java:62: * method declared to return Integer. Are such cases this subtle a fail in real life? Seems like this could be maddening to debug. http://gwt-code-reviews.appspot.com/1453811/diff/1/user/test/com/google/web/bindery/requestfactory/shared/TestRequestFactory.java File user/test/com/google/web/bindery/requestfactory/shared/TestRequestFactory.java (right): http://gwt-code-reviews.appspot.com/1453811/diff/1/user/test/com/google/web/bindery/requestfactory/shared/TestRequestFactory.java#newcode19 user/test/com/google/web/bindery/requestfactory/shared/TestRequestFactory.java:19: * Creates TestFooPolymorphicRequest. Does this test serve any purpose any more? If so, could you spell out what it is? http://gwt-code-reviews.appspot.com/1453811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
