LGTM
On Jun 13, 2011 6:04 PM, <[email protected]> wrote:
>
>
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
> File
>
dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
> (right):
>
>
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java#newcode97
>
dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java:97:
> if (expression.constant != null && expression.constant !=
> Constant.NotAConstant) {
> You mean the null check? Not sure, I copied the code from here:
>
>
http://www.google.com/codesearch#A1edwVHBClQ/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java&l=2634
>
> I must have run into a null case at some point.
>
> http://gwt-code-reviews.appspot.com/1447825/

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to