Reviewers: jlabanca, rchandia, rice, jaimeyap,
Description:
Adds hooks to Widget reduce MVP boilerplate and enshrines the app-wide
EventBus.
Also simplifies the custom event set used in the sample app,
demonstrating how a
single custom ActionEvent could cover most cases. And backs away from
the
self-injected presenter notion, it was making things more complicated
rather
than less.
Widgets have two big new features: they know about EventBus, and they
can have a
single IsWidgetDriver (read: presenter) that they can start and stop as
their
isVisible and isAttached states change.
1. Widget as event source
Widgets now have a setEventBus method, and also implement the
IsEventSource
Please review this at http://gwt-code-reviews.appspot.com/1449817/
Affected files:
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/MobileWebApp.gwt.xml
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/App.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplTablet.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/MobileWebApp.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/MobileWebAppShell.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ProvidesPresenter.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/AppActivityMapper.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/AppActivityMapperTablet.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/AppPlaceHistoryMapper.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskActivity.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditView.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskListActivity.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskListView.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/activity/TaskReadView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskEditView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskListView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.ui.xml
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/PieChart.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/ActionEvent.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/ActionNames.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/AddTaskEvent.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/EditingCanceledEvent.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/GoHomeEvent.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/TaskEditEvent.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/TaskListUpdateEvent.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/event/TaskSavedEvent.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskEditView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskListView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskReadView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/mobile/TaskProxyCell.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/place/AppPlaceHistoryMapper.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/place/TaskEditPlace.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/place/TaskListPlace.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/tablet/MobileWebAppShellTablet.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskEditView.java
M
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskReadView.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ui/OrientationHelper.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ui/PieChart.java
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/ui/WindowBasedOrientationHelper.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/task/TaskEditPresenter.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/task/TaskEditView.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/task/TaskPlace.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/task/TaskReadPresenter.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/task/TaskReadView.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/taskchart/TaskChartPresenter.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/tasklist/TaskListPlace.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/tasklist/TaskListPresenter.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/presenter/tasklist/TaskListView.java
A samples/mobilewebapp/src/main/java/com/google/gwt/sample/ui/UI.gwt.xml
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/ui/client/IsPresenter.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/ui/client/OrientationHelper.java
A
samples/mobilewebapp/src/main/java/com/google/gwt/sample/ui/client/WindowBasedOrientationHelper.java
M user/src/com/google/gwt/event/shared/ResettableEventBus.java
M user/src/com/google/gwt/user/client/ui/Composite.java
A user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
A user/src/com/google/gwt/user/client/ui/IsEventSource.java
A user/src/com/google/gwt/user/client/ui/IsWidgetDriver.java
M user/src/com/google/gwt/user/client/ui/Widget.java
M user/src/com/google/web/bindery/event/shared/HandlerRegistration.java
A user/src/com/google/web/bindery/event/shared/NullEventBus.java
M user/src/com/google/web/bindery/event/shared/ResettableEventBus.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
