http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsEventSource.java File user/src/com/google/gwt/user/client/ui/IsEventSource.java (right):
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsEventSource.java#newcode28 user/src/com/google/gwt/user/client/ui/IsEventSource.java:28: * event bus.
Perhaps the thing to do is provide a convenience setter for the string
case?
Object getEventSource() void setEventSource(Object) void setEventSourceName(String)
Would UiBinder not widen the string XML attribute value to an Object? Having a setEventSourcName(String) seem redundant when the only way to actually access it is through an Object-return method. http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsWidgetDriver.java File user/src/com/google/gwt/user/client/ui/IsWidgetDriver.java (right): http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsWidgetDriver.java#newcode53 user/src/com/google/gwt/user/client/ui/IsWidgetDriver.java:53: public interface IsWidgetDriver { DrivesWidgets SGTM. http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/web/bindery/event/shared/ResettableEventBus.java File user/src/com/google/web/bindery/event/shared/ResettableEventBus.java (right): http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/web/bindery/event/shared/ResettableEventBus.java#newcode37 user/src/com/google/web/bindery/event/shared/ResettableEventBus.java:37: public ResettableEventBus(EventBus wrappedBus, String name) { On 2011/06/14 18:34:41, rjrjr wrote:
You okay with the setEventSource(Object) / setEventSourceName(String)
notion to
keep uibinder simple?
If setEventSourceName(String) is necessary to make UiBinder work and just delegates over to setEventSource(), I think that's something that can be lived with. http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/web/bindery/event/shared/ResettableEventBus.java#newcode55 user/src/com/google/web/bindery/event/shared/ResettableEventBus.java:55: * Remove all handlers that have been added through this wrapper, and neuter
On 2011/06/14 15:05:48, jlabanca wrote: > We should rename the method to neuter()
Many APIs use shutdown() http://gwt-code-reviews.appspot.com/1449817/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
