LGTM
http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/gwt/core/client/impl/WeakMapping.java File user/src/com/google/gwt/core/client/impl/WeakMapping.java (right): http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/gwt/core/client/impl/WeakMapping.java#newcode104 user/src/com/google/gwt/core/client/impl/WeakMapping.java:104: for (;;) { why is this tight loop okay? What makes the thread sleep or whatever? http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/ProxyAutoBean.java File user/src/com/google/web/bindery/autobean/vm/impl/ProxyAutoBean.java (right): http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/ProxyAutoBean.java#newcode143 user/src/com/google/web/bindery/autobean/vm/impl/ProxyAutoBean.java:143: * elsewhere. The alternative is a massive memory leak. Don't understand this comment. How is it premature if nothing is referencing them? http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java File user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java (right): http://gwt-code-reviews.appspot.com/1451819/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java#newcode67 user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java:67: import com.google.web.bindery.requestfactory.vm.testing.UrlRequestTransport; Does this file belong in this patch? http://gwt-code-reviews.appspot.com/1451819/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
