http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):
http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461 user/src/com/google/gwt/user/tools/WebAppCreator.java:461: // Public builds generate a DTD reference. On 2011/06/17 13:41:13, pdr wrote:
// Public builds... -> // Generate a DTD reference.
Done. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode462 user/src/com/google/gwt/user/tools/WebAppCreator.java:462: String gwtModuleDtd = "\n<!-- Using DTD from SVN 'trunk'. You probably want to change this to a specific, release tagged, DTD -->" On 2011/06/17 13:41:13, pdr wrote:
Nit: Can you make this less than than 100 chars?
Done. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode469 user/src/com/google/gwt/user/tools/WebAppCreator.java:469: gwtModuleDtd = "\n<!-- When updating your version of GWT, also update this DTD reference -->" I clarified the comment. Strictly speaking, you can use the old DTD. Your IDE just won't know about any new GWT module features. This comment ensures developers have a chance to discover this. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode470 user/src/com/google/gwt/user/tools/WebAppCreator.java:470: + "\n<!DOCTYPE module PUBLIC \"-//Google Inc.//DTD Google Web Toolkit " On 2011/06/17 13:41:13, pdr wrote:
Nit: Can we shorten this by adding a newline here?
How's this? http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
