Reviewers: zundel,
http://gwt-code-reviews.appspot.com/1463803/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1463803/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java#newcode154
dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java:154:
return new SourceFileCompilationUnit(getResource(), getContentId(),
compiledClasses, types,
I was using a CompilationUnitBuilder without having called getSource()
and noticed contentId got passed into SFCU uninitialized.
Please review this at http://gwt-code-reviews.appspot.com/1463803/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
Index: dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
diff --git
a/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
b/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
index
48986cd1efe34d68ed81b346c2b990e95e096276..5ecf676f56e259c45bcc4c796f16d16afe522855
100644
--- a/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
+++ b/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
@@ -151,7 +151,7 @@ public abstract class CompilationUnitBuilder {
List<JDeclaredType> types, Dependencies dependencies,
Collection<? extends JsniMethod> jsniMethods, MethodArgNamesLookup
methodArgs,
CategorizedProblem[] problems) {
- return new SourceFileCompilationUnit(getResource(), contentId,
compiledClasses, types,
+ return new SourceFileCompilationUnit(getResource(), getContentId(),
compiledClasses, types,
dependencies, jsniMethods, methodArgs, problems,
getLastModified());
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
