Reviewers: tilmansp_google.com,

Description:
Fixing a bug in CellTree where pushing new data that renders to the same
content results in an invalid state where child are still attached to a
stale parent.  For example, consider a tree contains IDs that represent
objects, but renders the ID using the objects display name.  If two
objects with different IDs have the same display name, those two objects
will be rendered the same, which CellTree would optimize out.  Now, we
perform the detach/reattach logic for child nodes, but we still do not
reset the innerHTML.

Sorry for the auto-format and Java 1.6 @Override spam.  This is actually
a fairly small CL, but I reformatted the files to get rid of checkstyle
warnings while I was editing them.


Please review this at http://gwt-code-reviews.appspot.com/1466803/

Affected files:
  M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
  M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
  M user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
  M user/test/com/google/gwt/user/cellview/client/CellTreeTest.java
  M user/test/com/google/gwt/user/cellview/client/HasDataPresenterTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to