http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode39 user/src/com/google/gwt/core/client/ScriptInjector.java:39: * public void onFailure(Void reason) { Leaving reason as Void means there's no way to provide any kind of diagnostic message to the caller. You could make this parameterized by Exception to at least be able to provide a message string, and possibly a JavaScriptException if one is warranted. http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode177 user/src/com/google/gwt/core/client/ScriptInjector.java:177: public static final JavaScriptObject TOP_WINDOW = nativeTopWindow(); Why would an external caller use use TOP_WINDOW? If it's going to be public, javadoc it. http://gwt-code-reviews.appspot.com/1451818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
