LGTM. With nits.

http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java
File
user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java
(right):

http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java#newcode26
user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java:26:
* Tck Tests for the {@code constraints groups } package.
Extra space

http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java
File
user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java
(right):

http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java#newcode39
user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java:39:
builder.expect(TreeLogger.ERROR, //
Why the // at EOL?

http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java#newcode72
user/test/org/hibernate/jsr303/tck/tests/constraints/groups/DefaultGroupRedefinitionCompileTest.java:72:
GroupSequenceWithNoImplicitDefaultGroupValidatorFactory.GroupSequenceWithNoImplicitDefaultGroupValidator.class);
Line too long

http://gwt-code-reviews.appspot.com/1467803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to