LGTM On 2011/06/17 17:07:50, stephenh wrote: http://gwt-code-reviews.appspot.com/1465801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
(left):
http://gwt-code-reviews.appspot.com/1465801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java#oldcode96
dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java:96:
assert
typeName.equals(Shared.toTypeName(resource.getPath())); This constructor was only used once, and the typeName parameter was
calculated
the same way as in the 1-arg constructor, so it seemed like a safe simplification to remove this 2-arg cstr and not have the caller
create an
unneeded typeName local variable.
http://gwt-code-reviews.appspot.com/1465801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
