http://gwt-code-reviews.appspot.com/1455802/diff/11003/user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java File user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java (right):
http://gwt-code-reviews.appspot.com/1455802/diff/11003/user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java#newcode106 user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java:106: if (hyphenatedWord.exec(word) == null) { I'm not following why we need two regexps. It seems like we could use the groups already matched in the first regexp, or alternately just use string functions: !word.startsWith("-") word.substring(1, 2) word.substring(2) http://gwt-code-reviews.appspot.com/1455802/diff/11003/user/src/com/google/gwt/dom/builder/shared/StylesBuilder.java File user/src/com/google/gwt/dom/builder/shared/StylesBuilder.java (right): http://gwt-code-reviews.appspot.com/1455802/diff/11003/user/src/com/google/gwt/dom/builder/shared/StylesBuilder.java#newcode329 user/src/com/google/gwt/dom/builder/shared/StylesBuilder.java:329: * @param value the value On 2011/06/27 22:38:38, jlabanca wrote:
I remove the "value" @param from this method and the one below since
they don't
tell us anything.
Looks like you removed "name" instead. (For the name, we could say that we accept both camel and hyphenated names.) http://gwt-code-reviews.appspot.com/1455802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
