http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode80 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:80: public static boolean isValidModuleName(String moduleName) { Will this cause previously building modules to now have errors? http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode87 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:87: for (int i = 0; i < parts.length - 1; i++) { Should we issues a warning about a bad identifier on the last part of the module name? Maybe enforce it in the future? Or not? http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java (left): http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java#oldcode310 dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:310: throws UnableToCompleteException { so, this validation is needed only on nested modules, but not top-level ones? http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/test/com/google/gwt/dev/cfg/ModuleDefLoaderTest.java File dev/core/test/com/google/gwt/dev/cfg/ModuleDefLoaderTest.java (right): http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/test/com/google/gwt/dev/cfg/ModuleDefLoaderTest.java#newcode66 dev/core/test/com/google/gwt/dev/cfg/ModuleDefLoaderTest.java:66: "com.google.gwt.dev.cfg.testdata.naming.NestedInvalid", false); Maybe add a comment here, since this identifier looks ok, but the error is that this module inherits from a malformed module identifier (was confusing to me at first). http://gwt-code-reviews.appspot.com/1467810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
