Reviewers: zundel, jbrosenberg,

Message:
Hey guys,

Please review.  This fixes the front-end issue withe GwtAstBuilder,
bringing it up to parity with GenerateJavaAST.

However, there *is* in fact a bug in the backend.  See:
http://gwt-code-reviews.appspot.com/1470803/

But I want to go ahead and get this fix in, the bug has been around
forever, it would seem.

Description:
GWT AST now tracks method access.  This is used by UnifyAst to correctly
compute overrides.  Before, UnifyAst would allow a public method to
override a default-access method in a different package, which is
illegal.


Please review this at http://gwt-code-reviews.appspot.com/1470803/

Affected files:
  A dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/ResolveRebinds.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
  M dev/core/test/com/google/gwt/dev/jjs/impl/PrunerTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to