Reviewers: rchandia, jlabanca, eaf_google.com,
Description:
Fixing IsRenderable API step 2: pass in a stamper instead of the actual
ID.
As we discussed a few weeks ago, the goal here is to make the exact
scheme by which elements are marked and retrieved opaque to the
IsRenderable implementation. I thought I went about this in small steps:
1-) Fix the API and UiBinder to use a RenderableStamper class. This
class supports stamping SafeHtml and ElementBuilder, but also exposes
the token explicitly for backwards-compatibility (to keep the CL at a
manageable size)
2-) Fix all uses of RenderableStamper.geToken() to use either SafeHtml
or ElementBuilder. In particular I'm worried about performance
regressions if we use SafeHtml.
3-) Profit.
Please review this at http://gwt-code-reviews.appspot.com/1472801/
Affected files:
M
user/src/com/google/gwt/uibinder/elementparsers/IsRenderableInterpreter.java
M user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
M user/src/com/google/gwt/user/client/ui/Composite.java
M user/src/com/google/gwt/user/client/ui/IsRenderable.java
M user/src/com/google/gwt/user/client/ui/RenderablePanel.java
A user/src/com/google/gwt/user/client/ui/RenderableStamper.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
