http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java#newcode21 dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java:21: public enum AccessModifiers { Note, using <value>.ordinal() means that any changing in order is going to screw up the serialized tree. I suggest we either do something to protect against that in JMethod, or add a dire warning here against reordring the values (e.g. sorting them alphabetcially) http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java File dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode140 dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:140: this.access = access.ordinal(); danger! could lead to invalid serialized data if something seemingly trivial is changed in AccessModifiers (change sort order of members or add a new enum value). There will be no SerializationException either. Due to the potential for I'd prefer an explicit constant value/method declared for the enumerated type over relying on ordinal, which could change. http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2824 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2824: static AccessModifiers getAccessModifier(MethodBinding b) { Make this method AccessModifiers.fromMethodBinding()? http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
