Awesome! I haven't read the ExpectCollector code, and probably a few other lines of code, but the code reads good to me!
http://gwt-code-reviews.appspot.com/1473801/diff/1/user/src/com/google/web/bindery/requestfactory/apt/State.java File user/src/com/google/web/bindery/requestfactory/apt/State.java (right): http://gwt-code-reviews.appspot.com/1473801/diff/1/user/src/com/google/web/bindery/requestfactory/apt/State.java#newcode217 user/src/com/google/web/bindery/requestfactory/apt/State.java:217: messager.printMessage(Kind.WARNING, String.format(message, args), elt); Why a warning? Why not a note? just because it appears in the Eclipse editors? http://gwt-code-reviews.appspot.com/1473801/diff/1/user/test/com/google/web/bindery/requestfactory/apt/DiagnosticComparator.java File user/test/com/google/web/bindery/requestfactory/apt/DiagnosticComparator.java (right): http://gwt-code-reviews.appspot.com/1473801/diff/1/user/test/com/google/web/bindery/requestfactory/apt/DiagnosticComparator.java#newcode37 user/test/com/google/web/bindery/requestfactory/apt/DiagnosticComparator.java:37: return (int) p; Should probably be a Long.signum(p), just for the very improbable case where 'p' would overflow an 'int'. http://gwt-code-reviews.appspot.com/1473801/diff/1/user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java File user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java (right): http://gwt-code-reviews.appspot.com/1473801/diff/1/user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java#newcode75 user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java:75: return new URI("classpath:" + path); If "classpath:" works and we only create UriJavaFileObject from classes (via the create() factory method), why bother translating to a URL and then massage it to make it work? Why not simply doing: new URI("classpath:" + toLoad.getName().replace('.', '/') + ".java") ? (in addition to the URL, needed for getCharContent) http://gwt-code-reviews.appspot.com/1473801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
