LGTM++
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h File plugins/npapi/ScriptableInstance.h (right): http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h#newcode91 plugins/npapi/ScriptableInstance.h:91: static bool jsIdentitySafe; On 2011/07/07 16:24:11, conroy wrote:
On 2011/07/07 16:18:28, codefu wrote: > On 2011/07/07 15:19:54, conroy wrote: > > does this really need to be static? it should be fine to test/set
this per
> > connect > > The reason I think connect() was de-emphasized was the changing of
the
generated > hosted.html for each project, and thus every plugin's connect().
To be clear I meant to add code in the connect function body--not
changing its
API.
Though, this approach has the advantage that we can add UI later to tell developers to move to a newer version of Chrome for better performance. http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
