LGTM with a couple questions

Are there tests which verify this fixes the issue that caused the first
rollback?  (if not can you add a TODO)?


http://gwt-code-reviews.appspot.com/1474804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1474804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode504
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:504:
.getSourceInfo().getStartLine(), program.getQueryId(x), castableTypeMap,
I assume this is still the right thing to do here (return -1 if it's not
a JClassType?).

http://gwt-code-reviews.appspot.com/1474804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to