Reviewers: rjrjr, tbroyer,
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/RfApt.java
File user/src/com/google/web/bindery/requestfactory/apt/RfApt.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/RfApt.java#oldcode58
user/src/com/google/web/bindery/requestfactory/apt/RfApt.java:58: public
class RfApt extends AbstractProcessor {
Replaced by RfValidator.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/Deobfuscator.java
File
user/src/com/google/web/bindery/requestfactory/server/Deobfuscator.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/Deobfuscator.java#oldcode31
user/src/com/google/web/bindery/requestfactory/server/Deobfuscator.java:31:
class Deobfuscator {
Moved to vm.impl package.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/OperationData.java
File
user/src/com/google/web/bindery/requestfactory/server/OperationData.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/OperationData.java#oldcode24
user/src/com/google/web/bindery/requestfactory/server/OperationData.java:24:
class OperationData {
Moved to vm.impl package.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java
File
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java#oldcode92
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java:92:
public class RequestFactoryInterfaceValidator {
Dead.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
File
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
(right):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java#newcode37
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java:37:
import com.google.web.bindery.requestfactory.gwt.client.RequestBatcher;
Found that RequestBatcher was missing while trying to port the full JRE
stack tests to Android.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java#newcode115
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java:115:
public static class ClassLoaderLoader implements Loader {
These extra classes used to be in RFIV.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java
File
user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java
(right):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java#newcode39
user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java:39:
public static Builder load(Class<?> clazz, ClassLoader
resolveClassesWith) {
New method.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java#newcode109
user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java:109:
public Builder merge(Deobfuscator existing) {
New method.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java
File
user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java#oldcode35
user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java:35:
public class TypeTokenResolver {
Effectively rolled into Deobfuscator.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/BoxesAndPrimitivesJreTest.java
File
user/test/com/google/web/bindery/requestfactory/server/BoxesAndPrimitivesJreTest.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/BoxesAndPrimitivesJreTest.java#oldcode37
user/test/com/google/web/bindery/requestfactory/server/BoxesAndPrimitivesJreTest.java:37:
public class BoxesAndPrimitivesJreTest extends BoxesAndPrimitivesTest {
Removing these tests since they're rolled into RfValidatorTest.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
File
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java#oldcode46
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java:46:
public class RequestFactoryInterfaceValidatorTest extends TestCase {
RfValidatorTest was introduced in a previous commit and expanded in this
patch. This test can be retired since RFIV is being removed.
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java
File
user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java
(left):
http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java#oldcode18
user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java:18:
import com.google.gwt.dev.util.collect.HashSet;
Weird import problem.
Description:
Replace RequestFactoryInterfaceValidator with an
annotation-processor-based approach.
Add a ValidationTool to precompute server and JRE-client metadata.
Patch by: bobv
Review by: rjrjr, tbroyer
Please review this at http://gwt-code-reviews.appspot.com/1503804/
Affected files:
M requestfactory/build.xml
M samples/dynatablerf/build.xml
M
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
A
user/src/com/google/web/bindery/requestfactory/apt/DeobfuscatorBuilder.java
A
user/src/com/google/web/bindery/requestfactory/apt/DescriptorBuilder.java
M user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java
A
user/src/com/google/web/bindery/requestfactory/apt/ExtraTypesScanner.java
M user/src/com/google/web/bindery/requestfactory/apt/Messages.java
A
user/src/com/google/web/bindery/requestfactory/apt/ReferredTypesCollector.java
M
user/src/com/google/web/bindery/requestfactory/apt/RequestContextScanner.java
M
user/src/com/google/web/bindery/requestfactory/apt/RequestFactoryScanner.java
D user/src/com/google/web/bindery/requestfactory/apt/RfApt.java
M user/src/com/google/web/bindery/requestfactory/apt/RfValidator.java
M user/src/com/google/web/bindery/requestfactory/apt/ScannerBase.java
M user/src/com/google/web/bindery/requestfactory/apt/State.java
A user/src/com/google/web/bindery/requestfactory/apt/TypeComparator.java
A user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
D user/src/com/google/web/bindery/requestfactory/server/Deobfuscator.java
D user/src/com/google/web/bindery/requestfactory/server/OperationData.java
D
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java
M
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
M
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestFactory.java
A user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java
A
user/src/com/google/web/bindery/requestfactory/vm/impl/OperationData.java
D
user/src/com/google/web/bindery/requestfactory/vm/impl/TypeTokenResolver.java
M
user/test/com/google/web/bindery/requestfactory/apt/MyRequestContext.java
M
user/test/com/google/web/bindery/requestfactory/apt/MyRequestFactory.java
M user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java
M
user/test/com/google/web/bindery/requestfactory/server/BoxesAndPrimitivesJreTest.java
D
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
M
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryJreTest.java
M
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryPolymorphicJreTest.java
M user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java
M
user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
