Lets warn gwt-announce that the default will change next Tuesday, and
encourage them to try it out themselves in the meantime. Are you okay
driving that, and with waiting another week?
On Aug 2, 2011 6:33 AM, <her...@google.com> wrote:
> Reviewers: rjrjr,
>
> Description:
> Making lazy widgets generation the default option.
>
> Review by: rj...@google.com
>
> Please review this at http://gwt-code-reviews.appspot.com/1499809/
>
> Affected files:
> M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
> M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
>
>
> Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
> ===================================================================
> --- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (revision 10484)
> +++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (working copy)
> @@ -31,7 +31,7 @@
> rendering mode and make some widgets lazily created. This is still
> experimental
> but should be the default option in a soon future. -->
> <define-configuration-property name="UiBinder.useLazyWidgetBuilders"
> is-multi-valued="false"/>
> - <set-configuration-property name="UiBinder.useLazyWidgetBuilders"
> value="false"/>
> + <set-configuration-property name="UiBinder.useLazyWidgetBuilders"
> value="true"/>
>
> <generate-with class="com.google.gwt.uibinder.rebind.UiBinderGenerator">
> <when-type-assignable
> class="com.google.gwt.uibinder.client.UiRenderer"/>
> Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
> ===================================================================
> --- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
> (revision 10484)
> +++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(working
> copy)
> @@ -50,7 +50,7 @@
>
> private static final String XSS_SAFE_CONFIG_PROPERTY
> = "UiBinder.useSafeHtmlTemplates";
> private static final String LAZY_WIDGET_BUILDERS_PROPERTY
> = "UiBinder.useLazyWidgetBuilders";
> -
> +
> private static boolean gaveSafeHtmlWarning;
>
> /**
> @@ -212,7 +212,7 @@
> }
>
> private Boolean useLazyWidgetBuilders(MortalLogger logger,
> PropertyOracle propertyOracle) {
> - return extractConfigProperty(logger, propertyOracle,
> LAZY_WIDGET_BUILDERS_PROPERTY, false);
> + return extractConfigProperty(logger, propertyOracle,
> LAZY_WIDGET_BUILDERS_PROPERTY, true);
> }
>
> private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle
> propertyOracle) {
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to