http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml File samples/dynatablerf/build.xml (right):
http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml#newcode8 samples/dynatablerf/build.xml:8: <!-- Run the annotation processor --> This is a sample, can you be a bit more verbose? Annotation processor is an implementation detail. So really people "only" need to include this jar if they want compile time notification of RF errors. Which seems like a pretty big deal, especially if the rf server will no longer do such validation by default. Should we do something to force people to include this jar, like remove RF from gwt-user? I suppose that's a pretty drastic thing to do to existing users, although frankly it's tempting. Will they see any kind of warning if they don't include it ? I'm actually tempted to be drastic. http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/DeobfuscatorBuilder.java File user/src/com/google/web/bindery/requestfactory/apt/DeobfuscatorBuilder.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/DeobfuscatorBuilder.java#newcode38 user/src/com/google/web/bindery/requestfactory/apt/DeobfuscatorBuilder.java:38: * Visits a RequestFactory to create its associated DeobfuscatorBuilder type. Visits an RF to create itself? "...its associated {@link Deobfuscator}..." yes? http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/DescriptorBuilder.java File user/src/com/google/web/bindery/requestfactory/apt/DescriptorBuilder.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/DescriptorBuilder.java#newcode34 user/src/com/google/web/bindery/requestfactory/apt/DescriptorBuilder.java:34: * Builds descriptors from TypeMirrors for both simple types and methods. These descriptors are used by {@link ...} http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode52 user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:52: * for use by the ServiceLayer. Seems like this should either go into more detail on how to invoke / configure the tool, or point to such docs. http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java File user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java#newcode27 user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java:27: * Provides access to payload deobfuscation services. "...for both servers and clients." Is this the place to mention what GWT clients do instead? http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java#newcode37 user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java:37: * processor as part of the build process. @link, @see http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/OperationData.java File user/src/com/google/web/bindery/requestfactory/vm/impl/OperationData.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/src/com/google/web/bindery/requestfactory/vm/impl/OperationData.java#newcode52 user/src/com/google/web/bindery/requestfactory/vm/impl/OperationData.java:52: public Builder setClientMethodDescriptor(String clientMethodDescriptor) { nit: usually on a builder these are with*() methods http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/apt/MyRequestFactory.java File user/test/com/google/web/bindery/requestfactory/apt/MyRequestFactory.java (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/user/test/com/google/web/bindery/requestfactory/apt/MyRequestFactory.java#newcode27 user/test/com/google/web/bindery/requestfactory/apt/MyRequestFactory.java:27: @Expect(method = "contextMustBeAnnotated", args = "ReferencedContextWithoutMapping") Love @Expect http://gwt-code-reviews.appspot.com/1503804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
